* [PATCH robclark] drm: get_properties() can be static
2014-12-18 1:10 [robclark:atomic-properties 5/12] drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static? kbuild test robot
@ 2014-12-18 1:10 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2014-12-18 1:10 UTC (permalink / raw)
To: Rob Clark; +Cc: kbuild-all, David Airlie, dri-devel, linux-kernel
drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static?
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
drm_crtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index dcfd64e5..a80a29b 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1992,7 +1992,7 @@ static struct drm_encoder *drm_connector_get_encoder(struct drm_connector *conne
}
/* helper for getconnector and getproperties ioctls */
-int get_properties(struct drm_mode_object *obj, uint32_t __user *prop_ptr,
+static int get_properties(struct drm_mode_object *obj, uint32_t __user *prop_ptr,
uint64_t __user *prop_values, uint32_t *arg_count_props)
{
int props_count = obj->properties->count;
^ permalink raw reply [flat|nested] 2+ messages in thread
* [robclark:atomic-properties 5/12] drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static?
@ 2014-12-18 1:10 kbuild test robot
2014-12-18 1:10 ` [PATCH robclark] drm: get_properties() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2014-12-18 1:10 UTC (permalink / raw)
To: Rob Clark; +Cc: kbuild-all, David Airlie, dri-devel, linux-kernel
tree: git://people.freedesktop.org/~robclark/linux atomic-properties
head: 4e73d9848e88a1bdd90c2506457dc4e7583c2f58
commit: d9224ddf063bb89803a3f4cce2dfd3d2afcb4906 [5/12] drm: refactor getproperties/getconnector
reproduce:
# apt-get install sparse
git checkout d9224ddf063bb89803a3f4cce2dfd3d2afcb4906
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-18 1:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-18 1:10 [robclark:atomic-properties 5/12] drivers/gpu/drm/drm_crtc.c:1995:5: sparse: symbol 'get_properties' was not declared. Should it be static? kbuild test robot
2014-12-18 1:10 ` [PATCH robclark] drm: get_properties() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®