mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Gangadhar V <gangs.freelancer@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
Date: Sat, 20 Dec 2014 01:50:14 -0800	[thread overview]
Message-ID: <20141220095014.GA3381@hudson.localdomain> (raw)
In-Reply-To: <CAGVQi_1dMjxZuhSq0=aojyh9d-A10Pi+SWRR-4oXxbs1bTtqWQ@mail.gmail.com>

Gangadhar,

On Sat, Dec 20, 2014 at 03:13:10PM +0530, Gangadhar V wrote:
> Hi,
> It is Space coding Style issue which i found when running
> checkpatch.pl script on rtw_ap.c.
> 
> --Gangadhar V
> On Sat, Dec 20, 2014 at 2:44 PM, Jeremiah Mahler <jmmahler@gmail.com> wrote:
> > Gangadhar,
> >
> > On Sat, Dec 20, 2014 at 02:25:08PM +0530, Gangadhar wrote:
> >> From: gangadharv <gangs.freelancer@gmail.com>
> >>
> >> Fixed a Coding style issue.
> >
> > The description needs to be more specific?  What type of issue did you
> > fix?  How did you find this issue?
> >

Good, now describe this in the log message and submit a second
version of the patch.

> > [...]
> >
> > --
> > - Jeremiah Mahler

-- 
- Jeremiah Mahler

  reply	other threads:[~2014-12-20  9:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-20  8:55 Gangadhar
2014-12-20  9:10 ` Jeremiah Mahler
2014-12-20  9:14 ` Jeremiah Mahler
2014-12-20  9:43   ` Gangadhar V
2014-12-20  9:50     ` Jeremiah Mahler [this message]
2014-12-20 10:05 Gangadhar V
2014-12-20 10:30 ` Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141220095014.GA3381@hudson.localdomain \
    --to=jmmahler@gmail.com \
    --cc=gangs.freelancer@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®