From: Jeremiah Mahler <jmmahler@gmail.com>
To: Gangadhar V <gangs.freelancer@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu : rtw_ap.c : Fixed a space coding style issue.
Date: Sat, 20 Dec 2014 02:30:04 -0800 [thread overview]
Message-ID: <20141220103004.GA28416@hudson.localdomain> (raw)
In-Reply-To: <1419069934-10382-1-git-send-email-gangs.freelancer@gmail.com>
Gangadhar,
It is looking better but it still needs some work :)
Be sure to add a version number to your subject line when you release
a new version of your patch so reviewers know it is not an entirely
new patch.
[PATCH v2]
'git format-patch' will do this automatically with the '-v' option if you
are using that.
Also in the subject line, tags shouldn't include spaces.
e.g. 'rtl8188eu:' not 'rtl8188eu :'.
You don't need to include the file name ('rtw_ap.c') in the subject
line.
On Sat, Dec 20, 2014 at 03:35:34PM +0530, Gangadhar V wrote:
> Fixed a Space Coding style issue which was found when running checkpatch.pl script
> on rtw_ap.c.
Log messages should be less than 80 characters wide. I like to use 72
so that it doesn't wrap even after several replies.
>
> Signed-off-by: Gangadhar V <gangs.freelancer@gmail.com>
Is this your full legal name? Is your last name 'V'?
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index d61842e..da19145 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -509,7 +509,7 @@ void add_RATid(struct adapter *padapter, struct sta_info *psta, u8 rssi_level)
> tx_ra_bitmap |= ((raid<<28)&0xf0000000);
>
> DBG_88E("%s => mac_id:%d , raid:%d , bitmap = 0x%x, arg = 0x%x\n",
> - __func__ , psta->mac_id, raid , tx_ra_bitmap, arg);
> + __func__, psta->mac_id, raid, tx_ra_bitmap, arg);
This looks reasonable. There are only two checkpatch errors and you
fixed them both.
>
> /* bitmap[0:27] = tx_rate_bitmap */
> /* bitmap[28:31]= Rate Adaptive id */
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Time for version 3! :)
--
- Jeremiah Mahler
next prev parent reply other threads:[~2014-12-20 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 10:05 Gangadhar V
2014-12-20 10:30 ` Jeremiah Mahler [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-12-20 8:55 Gangadhar
2014-12-20 9:10 ` Jeremiah Mahler
2014-12-20 9:14 ` Jeremiah Mahler
2014-12-20 9:43 ` Gangadhar V
2014-12-20 9:50 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141220103004.GA28416@hudson.localdomain \
--to=jmmahler@gmail.com \
--cc=gangs.freelancer@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®