mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Jim Davis <jim.epost@gmail.com>
Cc: gregkh@linuxfoundation.org, shijie8@gmail.com,
	hans.verkuil@cisco.com, linux-media@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: tlg2300: disable building the driver
Date: Tue, 23 Dec 2014 15:02:32 -0200	[thread overview]
Message-ID: <20141223150232.1780e447@concha.lan.sisa.samsung.com> (raw)
In-Reply-To: <1419279945-16777-1-git-send-email-jim.epost@gmail.com>

Em Mon, 22 Dec 2014 13:25:45 -0700
Jim Davis <jim.epost@gmail.com> escreveu:

> This driver doesn't build with the current kernel, as reported in
> linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
> build system
> (https://www.mail-archive.com/linux-media@vger.kernel.org/msg83501.html).
> Since it's scheduled for removal, disable building it for now.
> 
> Signed-off-by: Jim Davis <jim.epost@gmail.com>
> ---
>  drivers/staging/media/tlg2300/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/media/tlg2300/Kconfig b/drivers/staging/media/tlg2300/Kconfig
> index 81784c6f7b88..87181b0f77fd 100644
> --- a/drivers/staging/media/tlg2300/Kconfig
> +++ b/drivers/staging/media/tlg2300/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_TLG2300
>  	select VIDEOBUF_VMALLOC
>  	select SND_PCM
>  	select VIDEOBUF_DVB
> +	depends on BROKEN

Actually, what it was missing on the original driver were to preserve
the original dependency. In this case, it should be dependent of
MEDIA_USB_SUPPORT.

> 
>  	---help---
>  	  This is a video4linux driver for Telegent tlg2300 based TV cards.


-- 

Cheers,
Mauro

      reply	other threads:[~2014-12-23 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22 20:25 Jim Davis
2014-12-23 17:02 ` Mauro Carvalho Chehab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141223150232.1780e447@concha.lan.sisa.samsung.com \
    --to=mchehab@osg.samsung.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hans.verkuil@cisco.com \
    --cc=jim.epost@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®