* [PATCH] media: tlg2300: disable building the driver
@ 2014-12-22 20:25 Jim Davis
2014-12-23 17:02 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 2+ messages in thread
From: Jim Davis @ 2014-12-22 20:25 UTC (permalink / raw)
To: mchehab, gregkh, shijie8, hans.verkuil, linux-media, devel, linux-kernel
Cc: Jim Davis
This driver doesn't build with the current kernel, as reported in
linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
build system
(https://www.mail-archive.com/linux-media@vger.kernel.org/msg83501.html).
Since it's scheduled for removal, disable building it for now.
Signed-off-by: Jim Davis <jim.epost@gmail.com>
---
drivers/staging/media/tlg2300/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/tlg2300/Kconfig b/drivers/staging/media/tlg2300/Kconfig
index 81784c6f7b88..87181b0f77fd 100644
--- a/drivers/staging/media/tlg2300/Kconfig
+++ b/drivers/staging/media/tlg2300/Kconfig
@@ -7,6 +7,7 @@ config VIDEO_TLG2300
select VIDEOBUF_VMALLOC
select SND_PCM
select VIDEOBUF_DVB
+ depends on BROKEN
---help---
This is a video4linux driver for Telegent tlg2300 based TV cards.
--
2.1.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: tlg2300: disable building the driver
2014-12-22 20:25 [PATCH] media: tlg2300: disable building the driver Jim Davis
@ 2014-12-23 17:02 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2014-12-23 17:02 UTC (permalink / raw)
To: Jim Davis; +Cc: gregkh, shijie8, hans.verkuil, linux-media, devel, linux-kernel
Em Mon, 22 Dec 2014 13:25:45 -0700
Jim Davis <jim.epost@gmail.com> escreveu:
> This driver doesn't build with the current kernel, as reported in
> linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day
> build system
> (https://www.mail-archive.com/linux-media@vger.kernel.org/msg83501.html).
> Since it's scheduled for removal, disable building it for now.
>
> Signed-off-by: Jim Davis <jim.epost@gmail.com>
> ---
> drivers/staging/media/tlg2300/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/tlg2300/Kconfig b/drivers/staging/media/tlg2300/Kconfig
> index 81784c6f7b88..87181b0f77fd 100644
> --- a/drivers/staging/media/tlg2300/Kconfig
> +++ b/drivers/staging/media/tlg2300/Kconfig
> @@ -7,6 +7,7 @@ config VIDEO_TLG2300
> select VIDEOBUF_VMALLOC
> select SND_PCM
> select VIDEOBUF_DVB
> + depends on BROKEN
Actually, what it was missing on the original driver were to preserve
the original dependency. In this case, it should be dependent of
MEDIA_USB_SUPPORT.
>
> ---help---
> This is a video4linux driver for Telegent tlg2300 based TV cards.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-23 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-22 20:25 [PATCH] media: tlg2300: disable building the driver Jim Davis
2014-12-23 17:02 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®