* Re: esp_scsi: make number of tags configurable
[not found] <20141209053657.75D6A66095A@gitolite.kernel.org>
@ 2014-12-10 10:16 ` Geert Uytterhoeven
2014-12-30 12:14 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-12-10 10:16 UTC (permalink / raw)
To: Hannes Reinecke, Christoph Hellwig; +Cc: Linux Kernel Mailing List, scsi
On Tue, Dec 9, 2014 at 6:36 AM, Linux Kernel Mailing List
<linux-kernel@vger.kernel.org> wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=3707a186c8970e3c4f3c8d9ccf4230b8657e919f
> Commit: 3707a186c8970e3c4f3c8d9ccf4230b8657e919f
> Parent: a87bf29362c763cf35faa17154b699471a8b902e
> Refname: refs/heads/master
> Author: Hannes Reinecke <hare@suse.de>
> AuthorDate: Mon Nov 24 15:37:20 2014 +0100
> Committer: Christoph Hellwig <hch@lst.de>
> CommitDate: Mon Nov 24 16:10:23 2014 +0100
>
> esp_scsi: make number of tags configurable
>
> Add a field 'num_tags' to the esp structure to allow drivers
> to overwrite the number of avialable tags if required.
> Default is ESP_DEFAULT_TAGS.
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Acked-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/scsi/esp_scsi.c | 12 ++++++------
> drivers/scsi/esp_scsi.h | 3 +--
> 2 files changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
> index 7e7687f..57ccb14 100644
> --- a/drivers/scsi/esp_scsi.c
> +++ b/drivers/scsi/esp_scsi.c
> @@ -2317,6 +2317,10 @@ int scsi_esp_register(struct esp *esp, struct device *dev)
> static int instance;
> int err;
>
> + if (!esp->num_tags)
> + esp->num_tags = ESP_DEFAULT_TAGS;
> + else if (esp->num_tags >= ESP_MAX_TAG)
drivers/scsi/esp_scsi.c: In function ‘scsi_esp_register’:
drivers/scsi/esp_scsi.c:2399: warning: comparison is always false due
to limited range of data type
ESP_MAX_TAG is 256, num_tags is u8.
> + esp->num_tags = ESP_MAX_TAG - 1;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread