From: Insop Song <insop.song@gainspeed.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Paul Bolle" <pebolle@tiscali.nl>,
"Monam Agarwal" <monamagarwal123@gmail.com>,
"Michał Bartoszkiewicz" <mbartoszkiewicz@gmail.com>,
"Rocco Folino" <lordzen87@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function
Date: Fri, 2 Jan 2015 12:14:26 -0800 [thread overview]
Message-ID: <20150102201426.GA15696@neon.local.cohere.net> (raw)
In-Reply-To: <1420129393-29038-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Reviewed-by: Insop Song <Insop.Song@gainspeed.com>
Thank you,
ISS
On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote:
> Remove the function bitswap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/gs_fpgaboot/io.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.c
> index b260e45..819db53 100644
> --- a/drivers/staging/gs_fpgaboot/io.c
> +++ b/drivers/staging/gs_fpgaboot/io.c
> @@ -79,15 +79,6 @@ void xl_shift_bytes_out(enum wbus bus_byte, unsigned char *pdata)
> /*
> * generic bit swap for xilinx SYSTEMMAP FPGA programming
> */
> -static inline unsigned char bitswap(unsigned char s)
> -{
> - unsigned char d;
> -
> - d = (((s&0x80)>>7) | ((s&0x40)>>5) | ((s&0x20)>>3) | ((s&0x10)>>1) |
> - ((s&0x08)<<1) | ((s&0x04)<<3) | ((s&0x02)<<5) | ((s&0x01)<<7));
> - return d;
> -}
> -
> void xl_program_b(int32_t i)
> {
> }
> --
> 1.7.10.4
>
prev parent reply other threads:[~2015-01-02 20:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-01 16:23 Rickard Strandqvist
2015-01-02 20:14 ` Insop Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102201426.GA15696@neon.local.cohere.net \
--to=insop.song@gainspeed.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lordzen87@gmail.com \
--cc=mbartoszkiewicz@gmail.com \
--cc=monamagarwal123@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pebolle@tiscali.nl \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®