* [PATCH] staging: gs_fpgaboot: io.c: Remove unused function
@ 2015-01-01 16:23 Rickard Strandqvist
2015-01-02 20:14 ` Insop Song
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-01 16:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, Insop Song
Cc: Rickard Strandqvist, Paul E. McKenney, Paul Bolle, Monam Agarwal,
Michał Bartoszkiewicz, Rocco Folino, devel, linux-kernel
Remove the function bitswap() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/gs_fpgaboot/io.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.c
index b260e45..819db53 100644
--- a/drivers/staging/gs_fpgaboot/io.c
+++ b/drivers/staging/gs_fpgaboot/io.c
@@ -79,15 +79,6 @@ void xl_shift_bytes_out(enum wbus bus_byte, unsigned char *pdata)
/*
* generic bit swap for xilinx SYSTEMMAP FPGA programming
*/
-static inline unsigned char bitswap(unsigned char s)
-{
- unsigned char d;
-
- d = (((s&0x80)>>7) | ((s&0x40)>>5) | ((s&0x20)>>3) | ((s&0x10)>>1) |
- ((s&0x08)<<1) | ((s&0x04)<<3) | ((s&0x02)<<5) | ((s&0x01)<<7));
- return d;
-}
-
void xl_program_b(int32_t i)
{
}
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function
2015-01-01 16:23 [PATCH] staging: gs_fpgaboot: io.c: Remove unused function Rickard Strandqvist
@ 2015-01-02 20:14 ` Insop Song
0 siblings, 0 replies; 2+ messages in thread
From: Insop Song @ 2015-01-02 20:14 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Greg Kroah-Hartman, Paul E. McKenney, Paul Bolle, Monam Agarwal,
Michał Bartoszkiewicz, Rocco Folino, devel, linux-kernel
Reviewed-by: Insop Song <Insop.Song@gainspeed.com>
Thank you,
ISS
On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote:
> Remove the function bitswap() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/gs_fpgaboot/io.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/gs_fpgaboot/io.c b/drivers/staging/gs_fpgaboot/io.c
> index b260e45..819db53 100644
> --- a/drivers/staging/gs_fpgaboot/io.c
> +++ b/drivers/staging/gs_fpgaboot/io.c
> @@ -79,15 +79,6 @@ void xl_shift_bytes_out(enum wbus bus_byte, unsigned char *pdata)
> /*
> * generic bit swap for xilinx SYSTEMMAP FPGA programming
> */
> -static inline unsigned char bitswap(unsigned char s)
> -{
> - unsigned char d;
> -
> - d = (((s&0x80)>>7) | ((s&0x40)>>5) | ((s&0x20)>>3) | ((s&0x10)>>1) |
> - ((s&0x08)<<1) | ((s&0x04)<<3) | ((s&0x02)<<5) | ((s&0x01)<<7));
> - return d;
> -}
> -
> void xl_program_b(int32_t i)
> {
> }
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-02 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-01 16:23 [PATCH] staging: gs_fpgaboot: io.c: Remove unused function Rickard Strandqvist
2015-01-02 20:14 ` Insop Song
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®