From: Andrew Morton <akpm@linux-foundation.org>
To: Kiran Raparthy <kiran.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org, Colin Cross <ccross@android.com>,
Jason Wessel <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
Android Kernel Team <kernel-team@android.com>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [RFC v4] debug: prevent entering debug mode on panic/exception.
Date: Mon, 5 Jan 2015 16:14:12 -0800 [thread overview]
Message-ID: <20150105161412.44f53313e1d771dc9f968264@linux-foundation.org> (raw)
In-Reply-To: <1419338309-16729-1-git-send-email-kiran.kumar@linaro.org>
On Tue, 23 Dec 2014 18:08:29 +0530 Kiran Raparthy <kiran.kumar@linaro.org> wrote:
> From: Colin Cross <ccross@android.com>
>
> debug: prevent entering debug mode on panic/exception.
>
> On non-developer devices, kgdb prevents the device from rebooting
> after a panic.
>
> Incase of panics and exceptions, to allow the device to reboot, prevent
> entering debug mode to avoid getting stuck waiting for the user to interact
> with debugger.
>
> To avoid entering the debugger on panic/exception without any extra
> configuration, panic_timeout is being used which can be set via
> /proc/sys/kernel/panic at run time and CONFIG_PANIC_TIMEOUT sets the default
> value.
>
> ...
>
hm. Why overload the meaning of panic_timeout in this fashion? If
someone is using kgdb and has panic_timeout set, they'll get quiet a
surprise.
Would it be cleaner/clearer to add some new standalone control for
this? One which is only present if CONFIG_KGDB.
We appear to have forgotten to document panic_timeout. Sigh.
next prev parent reply other threads:[~2015-01-06 0:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 12:38 Kiran Raparthy
2015-01-06 0:14 ` Andrew Morton [this message]
2015-01-06 5:01 ` Kiran Raparthy
2015-01-06 15:25 ` Daniel Thompson
2015-01-06 21:17 ` Andrew Morton
2015-01-07 3:36 ` Kiran Raparthy
2015-01-06 15:31 ` Daniel Thompson
2015-01-06 21:16 ` Andrew Morton
2015-01-07 8:57 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105161412.44f53313e1d771dc9f968264@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=jason.wessel@windriver.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=kiran.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®