From: Andrew Morton <akpm@linux-foundation.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Kiran Raparthy <kiran.kumar@linaro.org>,
linux-kernel@vger.kernel.org, Colin Cross <ccross@android.com>,
Jason Wessel <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
Android Kernel Team <kernel-team@android.com>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>
Subject: Re: [RFC v4] debug: prevent entering debug mode on panic/exception.
Date: Tue, 6 Jan 2015 13:17:58 -0800 [thread overview]
Message-ID: <20150106131758.0d6eb85279f678691443b8ef@linux-foundation.org> (raw)
In-Reply-To: <54ABFE7F.6090904@linaro.org>
On Tue, 06 Jan 2015 15:25:51 +0000 Daniel Thompson <daniel.thompson@linaro.org> wrote:
> >> To avoid entering the debugger on panic/exception without any extra
> >> configuration, panic_timeout is being used which can be set via
> >> /proc/sys/kernel/panic at run time and CONFIG_PANIC_TIMEOUT sets the default
> >> value.
> >>
> >> ...
> >>
> >
> > hm. Why overload the meaning of panic_timeout in this fashion? If
> > someone is using kgdb and has panic_timeout set, they'll get quiet a
> > surprise.
>
> Will they?
>
> Setting panic_timeout means the user explicitly requested that the
> machine try to perform an unattended reboot after a panic. Wedging in
> kgdb during panic on such a system absolutely contradicts the user's
> request to have an automated reboot.
>
> In this case it is not overloading the meaning... we are simply altering
> kgdb to properly honour the existing meaning.
>
> Changing the behaviour for exceptions as well as for panics *might*
> maybe veer into overloading but even there, I think we are simply better
> reflecting user intent. It is hard to imagine a user that wants
> automatic-reboot-on-panic being happy for the kernel to get stuck
> overnight just because of an oops.
OK, when you put it that way...
Kiran, could we please have an updated patch which includes the above
observations in the changelog and which documents panic_timeout?
next prev parent reply other threads:[~2015-01-06 21:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 12:38 Kiran Raparthy
2015-01-06 0:14 ` Andrew Morton
2015-01-06 5:01 ` Kiran Raparthy
2015-01-06 15:25 ` Daniel Thompson
2015-01-06 21:17 ` Andrew Morton [this message]
2015-01-07 3:36 ` Kiran Raparthy
2015-01-06 15:31 ` Daniel Thompson
2015-01-06 21:16 ` Andrew Morton
2015-01-07 8:57 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106131758.0d6eb85279f678691443b8ef@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ccross@android.com \
--cc=daniel.thompson@linaro.org \
--cc=jason.wessel@windriver.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@android.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=kiran.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®