[PATCH] workqueue.h: remove loops of single statement macros

[PATCH] workqueue.h: remove loops of single statement macros

[Valentin Rothberg]

checkpatch.pl complained about two single statement macros in
do while (0) loops.  The loops and the trailing semicolons are
now removed, which makes checkpatch happy and the two macros
consistent with the rest of the file.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 include/linux/workqueue.h | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index b996e6cd..74db135 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -220,14 +220,10 @@ static inline unsigned int work_static(struct work_struct *work) { return 0; }
 #endif
 
 #define INIT_WORK(_work, _func)						\
-	do {								\
-		__INIT_WORK((_work), (_func), 0);			\
-	} while (0)
+	__INIT_WORK((_work), (_func), 0)
 
 #define INIT_WORK_ONSTACK(_work, _func)					\
-	do {								\
-		__INIT_WORK((_work), (_func), 1);			\
-	} while (0)
+	__INIT_WORK((_work), (_func), 1)
 
 #define __INIT_DELAYED_WORK(_work, _func, _tflags)			\
 	do {								\
-- 
1.9.1

Re: [PATCH] workqueue.h: remove loops of single statement macros

[Tejun Heo]

On Tue, Jan 06, 2015 at 05:29:29PM +0100, Valentin Rothberg wrote:
> checkpatch.pl complained about two single statement macros in
> do while (0) loops.  The loops and the trailing semicolons are
> now removed, which makes checkpatch happy and the two macros
> consistent with the rest of the file.
> 
> Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>

Applied to wq/for-3.20.

Thanks.

-- 
tejun