mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: sunwxg <sun.wxg@gmail.com>
Cc: "Forest Bond" <forest@alittletooquiet.net>,
	"Guido Martínez" <guido@vanguardiasur.com.ar>,
	"Silvio Fricke" <silvio.fricke@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:vt6655 Add extern variable in head file
Date: Mon, 12 Jan 2015 19:36:40 -0800	[thread overview]
Message-ID: <20150113033640.GB31093@kroah.com> (raw)
In-Reply-To: <1418715590-10074-2-git-send-email-sun.wxg@gmail.com>

On Tue, Dec 16, 2014 at 03:39:50PM +0800, sunwxg wrote:
> From: Sun Wang <sun.wxg@gmail.com>
> 
> Subject: [PATCH] staging:vt6655 Add extern variable in head file

Why is this in the middle of the patch?  I would have to hand edit it
out :(

> 
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes. 

Always wrap your changelog at 72 columns.

Please fix up and resend.

thanks,

greg k-h

  reply	other threads:[~2015-01-13  5:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-16  7:39 sunwxg
2015-01-13  3:36 ` Greg Kroah-Hartman [this message]
     [not found] <20150113083114.GA57460@nas4free.local>
2015-01-13 17:12 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113033640.GB31093@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=guido@vanguardiasur.com.ar \
    --cc=linux-kernel@vger.kernel.org \
    --cc=silvio.fricke@gmail.com \
    --cc=sun.wxg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®