From: Greg KH <gregkh@linuxfoundation.org>
To: sun wang <sun.wxg@gmail.com>
Cc: Forest@nas4free.local, Bond@nas4free.local,
forest@alittletooquiet.net, Greg@nas4free.local,
Kroah-Hartman@nas4free.local, guido@vanguardiasur.com.ar,
Silvio@nas4free.local, Fricke@nas4free.local,
silvio.fricke@gmail.com, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging:vt6655 Add extern variable in head file
Date: Tue, 13 Jan 2015 09:12:39 -0800 [thread overview]
Message-ID: <20150113171239.GA12822@kroah.com> (raw)
In-Reply-To: <20150113083114.GA57460@nas4free.local>
On Tue, Jan 13, 2015 at 04:31:14PM +0800, sun wang wrote:
> Extern variable must be declared in head file. Compiler can catch the inconsistency when variable changes.
>
> Signed-off-by: Sun Wang <sun.wxg@gmail.com>
> ---
> drivers/staging/vt6655/ioctl.c | 1 -
> drivers/staging/vt6655/ioctl.h | 5 +++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/ioctl.c b/drivers/staging/vt6655/ioctl.c
> index 970e80d..716fc89 100644
> --- a/drivers/staging/vt6655/ioctl.c
> +++ b/drivers/staging/vt6655/ioctl.c
> @@ -31,7 +31,6 @@
> */
>
> #include "ioctl.h"
> -#include "iocmd.h"
> #include "mac.h"
> #include "card.h"
> #include "hostap.h"
> diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
> index 2dc5a57..42f6910 100644
> --- a/drivers/staging/vt6655/ioctl.h
> +++ b/drivers/staging/vt6655/ioctl.h
> @@ -30,6 +30,11 @@
> #define __IOCTL_H__
>
> #include "device.h"
> +#include "iocmd.h"
> +
> +#ifdef WPA_SM_Transtatus
> +extern SWPAResult wpa_Result;
> +#endif
I don't understand, what problem is this solving? This variable isn't
in the driver at all.
confused,
greg k-h
next parent reply other threads:[~2015-01-13 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150113083114.GA57460@nas4free.local>
2015-01-13 17:12 ` Greg KH [this message]
2014-12-16 7:39 sunwxg
2015-01-13 3:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113171239.GA12822@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Bond@nas4free.local \
--cc=Forest@nas4free.local \
--cc=Fricke@nas4free.local \
--cc=Greg@nas4free.local \
--cc=Kroah-Hartman@nas4free.local \
--cc=Silvio@nas4free.local \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=guido@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=silvio.fricke@gmail.com \
--cc=sun.wxg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®