* [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()
@ 2015-01-13 16:38 David Howells
2015-01-13 17:09 ` Al Viro
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: David Howells @ 2015-01-13 16:38 UTC (permalink / raw)
To: jesper.nilsson, viro
Cc: linux-fsdevel, dhowells, linux-kernel, linux-cris-kernel
Convert file->f_dentry->d_inode to file_inode() so as to get layered
filesystems right.
Found with: git grep '[.>]f_dentry'
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/cris/arch-v32/drivers/sync_serial.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
index 08a313fc2241..e9b6de2b46a0 100644
--- a/arch/cris/arch-v32/drivers/sync_serial.c
+++ b/arch/cris/arch-v32/drivers/sync_serial.c
@@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
struct timespec *ts)
{
unsigned long flags;
- int dev = MINOR(file->f_dentry->d_inode->i_rdev);
+ int dev = MINOR(file_inode(file_inode)->i_rdev);
int avail;
struct sync_port *port;
unsigned char *start;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()
2015-01-13 16:38 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() David Howells
@ 2015-01-13 17:09 ` Al Viro
2015-01-13 17:19 ` Marc Dionne
2015-01-13 17:51 ` David Howells
2 siblings, 0 replies; 4+ messages in thread
From: Al Viro @ 2015-01-13 17:09 UTC (permalink / raw)
To: David Howells
Cc: jesper.nilsson, linux-fsdevel, linux-kernel, linux-cris-kernel
On Tue, Jan 13, 2015 at 04:38:32PM +0000, David Howells wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
ACK. I wonder how that got missed during f_dentry elimination - even the
macro is gone these days...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()
2015-01-13 16:38 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() David Howells
2015-01-13 17:09 ` Al Viro
@ 2015-01-13 17:19 ` Marc Dionne
2015-01-13 17:51 ` David Howells
2 siblings, 0 replies; 4+ messages in thread
From: Marc Dionne @ 2015-01-13 17:19 UTC (permalink / raw)
To: David Howells
Cc: jesper.nilsson, Al Viro, linux-fsdevel,
Linux Kernel Mailing List, linux-cris-kernel
On Tue, Jan 13, 2015 at 12:38 PM, David Howells <dhowells@redhat.com> wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
>
> Signed-off-by: David Howells <dhowells@redhat.com>
> ---
>
> arch/cris/arch-v32/drivers/sync_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..e9b6de2b46a0 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
> struct timespec *ts)
> {
> unsigned long flags;
> - int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> + int dev = MINOR(file_inode(file_inode)->i_rdev);
Shouldn't that be file_inode(file) ?
> int avail;
> struct sync_port *port;
> unsigned char *start;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Marc
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode()
2015-01-13 16:38 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() David Howells
2015-01-13 17:09 ` Al Viro
2015-01-13 17:19 ` Marc Dionne
@ 2015-01-13 17:51 ` David Howells
2 siblings, 0 replies; 4+ messages in thread
From: David Howells @ 2015-01-13 17:51 UTC (permalink / raw)
To: Marc Dionne
Cc: dhowells, jesper.nilsson, Al Viro, linux-fsdevel,
Linux Kernel Mailing List, linux-cris-kernel
Marc Dionne <marc.c.dionne@gmail.com> wrote:
> Shouldn't that be file_inode(file) ?
Bah, yes.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-13 17:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-13 16:38 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() David Howells
2015-01-13 17:09 ` Al Viro
2015-01-13 17:19 ` Marc Dionne
2015-01-13 17:51 ` David Howells
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome