From: Greg KH <gregkh@linuxfoundation.org>
To: Emrys Bayliss <emrys@paradise.net.nz>
Cc: forest@alittletooquiet.net, tvboxspy@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: vt6656: Code cleanup: remove unreachable return
Date: Tue, 13 Jan 2015 09:13:54 -0800 [thread overview]
Message-ID: <20150113171354.GB12822@kroah.com> (raw)
In-Reply-To: <1421168860-30054-1-git-send-email-emrys@paradise.net.nz>
On Wed, Jan 14, 2015 at 04:07:40AM +1100, Emrys Bayliss wrote:
> This patch removes an unnecessary return statement that cannot be reached.
>
> Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz>
> ---
> drivers/staging/vt6656/rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index ea5140a..0cce140 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -574,8 +574,6 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context,
>
> return vnt_rxtx_datahead_g(tx_context, &buf->data_head);
> }
> -
> - return 0;
> }
>
> static u16 vnt_rxtx_rts(struct vnt_usb_send_context *tx_context,
> --
> 2.2.1
You already sent this patch before and it was accepted, right? If so,
please always tell me, I have no short term memory for patches as I get
1000 emails a day to deal with. Always properly version your patches if
you need/want it to superseed a previous patch.
dropped from my queue due to confusion,
greg k-h
prev parent reply other threads:[~2015-01-13 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:07 Emrys Bayliss
2015-01-13 17:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113171354.GB12822@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=emrys@paradise.net.nz \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®