mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] Staging: vt6656: Code cleanup: remove unreachable return
@ 2015-01-13 17:07 Emrys Bayliss
  2015-01-13 17:13 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Emrys Bayliss @ 2015-01-13 17:07 UTC (permalink / raw)
  To: forest, gregkh, tvboxspy, emrys; +Cc: devel, linux-kernel

This patch removes an unnecessary return statement that cannot be reached.

Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz>
---
 drivers/staging/vt6656/rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index ea5140a..0cce140 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -574,8 +574,6 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context,
 
 		return vnt_rxtx_datahead_g(tx_context, &buf->data_head);
 	}
-
-	return 0;
 }
 
 static u16 vnt_rxtx_rts(struct vnt_usb_send_context *tx_context,
-- 
2.2.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: vt6656: Code cleanup: remove unreachable return
  2015-01-13 17:07 [PATCH] Staging: vt6656: Code cleanup: remove unreachable return Emrys Bayliss
@ 2015-01-13 17:13 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-01-13 17:13 UTC (permalink / raw)
  To: Emrys Bayliss; +Cc: forest, tvboxspy, devel, linux-kernel

On Wed, Jan 14, 2015 at 04:07:40AM +1100, Emrys Bayliss wrote:
> This patch removes an unnecessary return statement that cannot be reached.
> 
> Signed-off-by: Emrys Bayliss <emrys@paradise.net.nz>
> ---
>  drivers/staging/vt6656/rxtx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index ea5140a..0cce140 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -574,8 +574,6 @@ static u16 vnt_fill_cts_head(struct vnt_usb_send_context *tx_context,
>  
>  		return vnt_rxtx_datahead_g(tx_context, &buf->data_head);
>  	}
> -
> -	return 0;
>  }
>  
>  static u16 vnt_rxtx_rts(struct vnt_usb_send_context *tx_context,
> -- 
> 2.2.1

You already sent this patch before and it was accepted, right?  If so,
please always tell me, I have no short term memory for patches as I get
1000 emails a day to deal with.  Always properly version your patches if
you need/want it to superseed a previous patch.

dropped from my queue due to confusion,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-13 17:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-13 17:07 [PATCH] Staging: vt6656: Code cleanup: remove unreachable return Emrys Bayliss
2015-01-13 17:13 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®