[PATCH] arm: mach-versatile: core: Remove unused function

[PATCH] arm: mach-versatile: core: Remove unused function

[Rickard Strandqvist]

Remove the function versatile_leds_event() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 arch/arm/mach-versatile/core.c |   37 -------------------------------------
 1 file changed, 37 deletions(-)

diff --git a/arch/arm/mach-versatile/core.c b/arch/arm/mach-versatile/core.c
index 08fb8c8..6ea09fe 100644
--- a/arch/arm/mach-versatile/core.c
+++ b/arch/arm/mach-versatile/core.c
@@ -728,43 +728,6 @@ struct of_dev_auxdata versatile_auxdata_lookup[] __initdata = {
 };
 #endif
 
-#ifdef CONFIG_LEDS
-#define VA_LEDS_BASE (__io_address(VERSATILE_SYS_BASE) + VERSATILE_SYS_LED_OFFSET)
-
-static void versatile_leds_event(led_event_t ledevt)
-{
-	unsigned long flags;
-	u32 val;
-
-	local_irq_save(flags);
-	val = readl(VA_LEDS_BASE);
-
-	switch (ledevt) {
-	case led_idle_start:
-		val = val & ~VERSATILE_SYS_LED0;
-		break;
-
-	case led_idle_end:
-		val = val | VERSATILE_SYS_LED0;
-		break;
-
-	case led_timer:
-		val = val ^ VERSATILE_SYS_LED1;
-		break;
-
-	case led_halted:
-		val = 0;
-		break;
-
-	default:
-		break;
-	}
-
-	writel(val, VA_LEDS_BASE);
-	local_irq_restore(flags);
-}
-#endif	/* CONFIG_LEDS */
-
 void versatile_restart(enum reboot_mode mode, const char *cmd)
 {
 	void __iomem *sys = __io_address(VERSATILE_SYS_BASE);
-- 
1.7.10.4

Re: [PATCH] arm: mach-versatile: core: Remove unused function

[Linus Walleij]

On Sat, Jan 3, 2015 at 5:52 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:

> Remove the function versatile_leds_event() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

That's right, the code was made redundant in
commit e031cd513ec2ff661465dc1198220075719e72d1
"ARM: mach-realview and mach-versatile: retire custom LED code"

ARM SoC folks: I suggest you apply this patch directly to your cleanup
branch.

Yours,
Linus Walleij

Re: [PATCH] arm: mach-versatile: core: Remove unused function

[Olof Johansson]

On Wed, Jan 14, 2015 at 12:53:07PM +0100, Linus Walleij wrote:
> On Sat, Jan 3, 2015 at 5:52 PM, Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se> wrote:
> 
> > Remove the function versatile_leds_event() that is not used anywhere.
> >
> > This was partially found by using a static code analysis program called cppcheck.
> >
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> That's right, the code was made redundant in
> commit e031cd513ec2ff661465dc1198220075719e72d1
> "ARM: mach-realview and mach-versatile: retire custom LED code"
> 
> ARM SoC folks: I suggest you apply this patch directly to your cleanup
> branch.

Thanks, applied with a minor tweak to the patch subject.


-Olof