* Re: [dm-devel] [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region [not found] <1421723781-21984-1-git-send-email-xerofoify@gmail.com> @ 2015-01-20 11:19 ` Alasdair G Kergon [not found] ` <54BE3DAA.5080900@gmail.com> 0 siblings, 1 reply; 2+ messages in thread From: Alasdair G Kergon @ 2015-01-20 11:19 UTC (permalink / raw) To: Nicholas Krause; +Cc: agk, linux-raid, dm-devel, linux-kernel, snitzer On Mon, Jan 19, 2015 at 10:16:21PM -0500, Nicholas Krause wrote: > Removes the no longer needed fix me comment questioning if we need to remove > the structure pointer,rh as defined as a structure of type dsm_region_hash > from the definition of the structure, dm_region. Furthermore this pointer is > needed in order for various functions to run and build successfully in the file, > dm-region-hash.c. You've misunderstood the comment! Is there a better alternative to having every dm_region struct store its own copy of this pointer? Alasdair ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <54BE3DAA.5080900@gmail.com>]
* Re: [dm-devel] [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region [not found] ` <54BE3DAA.5080900@gmail.com> @ 2015-01-20 11:40 ` Alasdair G Kergon 0 siblings, 0 replies; 2+ messages in thread From: Alasdair G Kergon @ 2015-01-20 11:40 UTC (permalink / raw) To: nick; +Cc: agk, linux-raid, dm-devel, linux-kernel, snitzer On Tue, Jan 20, 2015 at 06:36:10AM -0500, nick wrote: > Unless we use a union or something similar there seems to be no easy > way without rewriting a lot of an already function driver file. The comment does not restrict itself to 'easy ways'. Alasdair ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-20 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1421723781-21984-1-git-send-email-xerofoify@gmail.com>
2015-01-20 11:19 ` [dm-devel] [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region Alasdair G Kergon
[not found] ` <54BE3DAA.5080900@gmail.com>
2015-01-20 11:40 ` Alasdair G Kergon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®