From: Borislav Petkov <bp@suse.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
Chen Gong <gong.chen@linux.intel.com>
Subject: Re: [PATCH] x86, mce: Always fall into mcelog path, regardless of what notifiers returned
Date: Fri, 30 Jan 2015 18:38:30 +0100 [thread overview]
Message-ID: <20150130173830.GB1893@pd.tnic> (raw)
In-Reply-To: <7567eecb772846677994ace8ba1ca0c58df1fb9a.1422638760.git.tony.luck@intel.com>
On Fri, Jan 30, 2015 at 09:29:47AM -0800, Tony Luck wrote:
> This has been broken for a while - but we should not allow code
> registered on the x86_mce_decoder_chain to bypass sending machine
> check logs to /dev/mcelog.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>
> Yes, we've had this conversation before and I wimped out and didn't
> push the issue. But userspace is broken. People are complaining to
> me that errors don't show up in /var/log/mcelog even though they
> started the mcelog(8) daemon.
We need to fix this differently - on AMD, mcelog is not needed as the
decoding is done in the kernel.
We could use mce_register_decode_chain() for callers to state what they
want.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2015-01-30 17:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 17:29 Tony Luck
2015-01-30 17:38 ` Borislav Petkov [this message]
2015-01-30 18:16 ` [PATCHv2] x86, mce: Kernel does full decoding for AMD, others still need /dev/mcelog reports Tony Luck
2015-01-30 19:13 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130173830.GB1893@pd.tnic \
--to=bp@suse.de \
--cc=gong.chen@linux.intel.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®