* [PATCH v2] checkpatch: enhance check for seq_printf uses that could be seq_puts
@ 2015-01-31 22:38 Heba Aamer
0 siblings, 0 replies; only message in thread
From: Heba Aamer @ 2015-01-31 22:38 UTC (permalink / raw)
To: apw, joe; +Cc: linux-kernel
This patch enhances the check for seq_printf uses that could
be seq_puts.
It was considering the escape of % is \%, but it is %%.
This led to skipping some valid cases related to that warning.
Signed-off-by: Heba Aamer <heba93aamer@gmail.com>
---
v2: remove not needed if condition
scripts/checkpatch.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0bb6d6..e3ebfe6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4804,7 +4804,8 @@ sub process {
# check for seq_printf uses that could be seq_puts
if ($sline =~ /\bseq_printf\s*\(.*"\s*\)\s*;\s*$/) {
my $fmt = get_quoted_string($line, $rawline);
- if ($fmt ne "" && $fmt !~ /[^\\]\%/) {
+ $fmt = s/%%//g;
+ if ($fmt !~ /%/) {
if (WARN("PREFER_SEQ_PUTS",
"Prefer seq_puts to seq_printf\n" . $herecurr) &&
$fix) {
--
1.7.9.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-31 22:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-31 22:38 [PATCH v2] checkpatch: enhance check for seq_printf uses that could be seq_puts Heba Aamer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®