From: Mark Brown <broonie@kernel.org>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] spi: atmel: cleanup wait_for_completion return handling
Date: Wed, 4 Feb 2015 11:26:12 +0000 [thread overview]
Message-ID: <20150204112612.GX21293@sirena.org.uk> (raw)
In-Reply-To: <1422891811-28541-1-git-send-email-hofrat@osadl.org>
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
On Mon, Feb 02, 2015 at 10:43:31AM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch adds an appropriate variable and fixes up the assignment. It removes
> the else branch as the only thing it was doing is assigning ret = 0; - but
> ret is never used thereafter so that is not needed. As the string in
> dev_err already states "timeout" there is little point in printing the 0.
> A typo in "trasfer" -> transfer is also fixed.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-02-04 11:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 15:43 Nicholas Mc Guire
2015-02-04 9:18 ` Nicolas Ferre
2015-02-04 11:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150204112612.GX21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®