From: Peter Zijlstra <peterz@infradead.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
paul@pwsan.com, linux-omap@vger.kernel.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, balbi@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning
Date: Fri, 6 Feb 2015 19:32:05 +0100 [thread overview]
Message-ID: <20150206183205.GS21418@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <54D4E64C.7060208@ti.com>
On Fri, Feb 06, 2015 at 06:05:32PM +0200, Peter Ujfalusi wrote:
> Certainly looks much simpler, but it adds quite a bit of data to the
> omap_hwmod struct, and we have a _lot_ of them for omap2plus configuration.
>
> ls -al vmlinux
>
> w/o any the lockdep warning fixes:
> 110109168
>
> With my series applied:
> 110112031 (base + 2863)
>
> With setting individual lockdep class:
> 110114275 (base + 5107)
>
> I certainly like the lockdep_set_class() way since it is cleaner, but it adds
> almost double amount of bytes to the kernel.
Yeah, I've never really bothered with data too much, its a debug
feature. So lock_class_key is 8 bytes, and strictly speaking you could
union them over other fields, all we really need is unique addresses, we
don't actually use the storage.
next prev parent reply other threads:[~2015-02-06 18:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 12:48 Peter Ujfalusi
2015-02-06 12:48 ` [PATCH 1/2] ARM: omap2+: omap_hwmod: Use _nested version of spinlock for oh->_lock Peter Ujfalusi
2015-02-06 12:48 ` [PATCH 2/2] ARM: DRA7: hwmod_data: Change locked_class for atl hwmod Peter Ujfalusi
2015-02-06 14:13 ` [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning Peter Zijlstra
2015-02-06 16:05 ` Peter Ujfalusi
2015-02-06 18:32 ` Peter Zijlstra [this message]
2015-02-06 19:26 ` Peter Ujfalusi
2015-02-09 8:27 ` Peter Ujfalusi
2015-02-09 9:23 ` Peter Zijlstra
2015-02-09 16:00 ` Paul Walmsley
2015-02-09 17:31 ` Tony Lindgren
2015-02-09 18:55 ` Paul Walmsley
2015-02-09 22:16 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150206183205.GS21418@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome