* [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.
@ 2015-02-05 5:16 Wang Long
2015-02-09 15:57 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: Wang Long @ 2015-02-05 5:16 UTC (permalink / raw)
To: rostedt, mingo, corbet; +Cc: linux-doc, linux-kernel, peifeiyue, long.wanglong
The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
because the command `echo -1 > set_ftrace_pid` will output the following:
"bash: echo: write error: Invalid argument".
so update the file Documentation/trace/ftrace.txt.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
Documentation/trace/ftrace.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
index 8408e04..572ca92 100644
--- a/Documentation/trace/ftrace.txt
+++ b/Documentation/trace/ftrace.txt
@@ -1740,7 +1740,7 @@ no pid
yum-updatesd-3111 [003] 1637.254683: lock_hrtimer_base <-hrtimer_try_to_cancel
yum-updatesd-3111 [003] 1637.254685: fget_light <-do_sys_poll
yum-updatesd-3111 [003] 1637.254686: pipe_poll <-do_sys_poll
-# echo -1 > set_ftrace_pid
+# echo > set_ftrace_pid
# cat trace |head
# tracer: function
#
--
1.8.3.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.
2015-02-05 5:16 [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter Wang Long
@ 2015-02-09 15:57 ` Jonathan Corbet
2015-02-09 16:02 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2015-02-09 15:57 UTC (permalink / raw)
To: Wang Long; +Cc: rostedt, mingo, linux-doc, linux-kernel, peifeiyue
On Thu, 5 Feb 2015 05:16:14 +0000
Wang Long <long.wanglong@huawei.com> wrote:
> The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
> because the command `echo -1 > set_ftrace_pid` will output the following:
> "bash: echo: write error: Invalid argument".
>
> so update the file Documentation/trace/ftrace.txt.
So this is in my pile for the docs tree, but I was hoping to see an ack
from Steve first...?
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter.
2015-02-09 15:57 ` Jonathan Corbet
@ 2015-02-09 16:02 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2015-02-09 16:02 UTC (permalink / raw)
To: Jonathan Corbet; +Cc: Wang Long, mingo, linux-doc, linux-kernel, peifeiyue
On Mon, 9 Feb 2015 10:57:29 -0500
Jonathan Corbet <corbet@lwn.net> wrote:
> On Thu, 5 Feb 2015 05:16:14 +0000
> Wang Long <long.wanglong@huawei.com> wrote:
>
> > The command `echo > set_ftrace_pid` should be used to clean the filter quietly.
> > because the command `echo -1 > set_ftrace_pid` will output the following:
> > "bash: echo: write error: Invalid argument".
> >
> > so update the file Documentation/trace/ftrace.txt.
>
> So this is in my pile for the docs tree, but I was hoping to see an ack
> from Steve first...?
Yeah, I meant to reply but got distracted ;-)
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-09 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-05 5:16 [PATCH] Documentation: Fix the wrong command `echo -1 > set_ftrace_pid` for cleaning the filter Wang Long
2015-02-09 15:57 ` Jonathan Corbet
2015-02-09 16:02 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®