From: Andrew Morton <akpm@linux-foundation.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: a.zummo@towertech.it, kgene@kernel.org,
kyungmin.park@samsung.com, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] rtc: s3c: Fix the duplicate clock control
Date: Tue, 10 Feb 2015 12:31:17 -0800 [thread overview]
Message-ID: <20150210123117.b8f3c446137f8d5fd90dda35@linux-foundation.org> (raw)
In-Reply-To: <1423537650-11832-1-git-send-email-cw00.choi@samsung.com>
On Tue, 10 Feb 2015 12:07:30 +0900 Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch fixes the duplicate clock control and split out clock control
> function as s3c_rtc_enable_clk()/s3c_rtc_disable_clk() to simplify code.
"fixes"? This is a pretty big patch and it is poorly described.
Please provide a complete description of what is wrong with the
original code and how this patch alters it. Please be sure to describe
the user-visible effects of the bug.
prev parent reply other threads:[~2015-02-10 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 3:07 Chanwoo Choi
2015-02-10 20:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210123117.b8f3c446137f8d5fd90dda35@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=cw00.choi@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®