* [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe
@ 2015-02-13 15:36 Boris Brezillon
2015-02-13 16:05 ` Sylvain Rochet
0 siblings, 1 reply; 2+ messages in thread
From: Boris Brezillon @ 2015-02-13 15:36 UTC (permalink / raw)
To: Nicolas Ferre, Jean-Christophe Plagniol-Villard,
Alexandre Belloni, David Airlie, dri-devel
Cc: Sylvain Rochet, linux-arm-kernel, linux-kernel, Boris Brezillon
Remove a useless pm_runtime_put_sync leading to unbalanced
usage_count.
Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
index 7320a6c..c1cb174 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
@@ -311,8 +311,6 @@ static int atmel_hlcdc_dc_load(struct drm_device *dev)
pm_runtime_enable(dev->dev);
- pm_runtime_put_sync(dev->dev);
-
ret = atmel_hlcdc_dc_modeset_init(dev);
if (ret < 0) {
dev_err(dev->dev, "failed to initialize mode setting\n");
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe
2015-02-13 15:36 [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe Boris Brezillon
@ 2015-02-13 16:05 ` Sylvain Rochet
0 siblings, 0 replies; 2+ messages in thread
From: Sylvain Rochet @ 2015-02-13 16:05 UTC (permalink / raw)
To: Boris Brezillon
Cc: Nicolas Ferre, Jean-Christophe Plagniol-Villard,
Alexandre Belloni, David Airlie, dri-devel, linux-arm-kernel,
linux-kernel
Hello Boris,
On Fri, Feb 13, 2015 at 04:36:25PM +0100, Boris Brezillon wrote:
> Remove a useless pm_runtime_put_sync leading to unbalanced
> usage_count.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Reported-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> ---
Indeed, this is actually a necessary fix for my "drm: atmel-hlcdc: PM
support" series.
Tested-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Reviewed-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Sylvain
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-13 16:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-13 15:36 [PATCH] drm: atmel-hlcdc: remove useless pm_runtime_put_sync in probe Boris Brezillon
2015-02-13 16:05 ` Sylvain Rochet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®