* [PATCH 1/2] ocfs2: remove useless if statement
@ 2015-02-17 7:13 Daeseok Youn
2015-02-17 23:30 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2015-02-17 7:13 UTC (permalink / raw)
To: mfasheh, akpm; +Cc: jlbec, ocfs2-devel, linux-kernel
The Local variable "i" in for loop is always less then
O2CB_MAP_STABILIZE_COUNT.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
fs/ocfs2/stack_o2cb.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
index 1724d43..813d726 100644
--- a/fs/ocfs2/stack_o2cb.c
+++ b/fs/ocfs2/stack_o2cb.c
@@ -295,8 +295,8 @@ static int o2cb_cluster_check(void)
set_bit(node_num, netmap);
if (!memcmp(hbmap, netmap, sizeof(hbmap)))
return 0;
- if (i < O2CB_MAP_STABILIZE_COUNT)
- msleep(1000);
+
+ msleep(1000);
}
printk(KERN_ERR "o2cb: This node could not connect to nodes:");
--
1.7.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] ocfs2: remove useless if statement
2015-02-17 7:13 [PATCH 1/2] ocfs2: remove useless if statement Daeseok Youn
@ 2015-02-17 23:30 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2015-02-17 23:30 UTC (permalink / raw)
To: Daeseok Youn; +Cc: mfasheh, jlbec, ocfs2-devel, linux-kernel
On Tue, 17 Feb 2015 16:13:50 +0900 Daeseok Youn <daeseok.youn@gmail.com> wrote:
> The Local variable "i" in for loop is always less then
> O2CB_MAP_STABILIZE_COUNT.
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> fs/ocfs2/stack_o2cb.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
> index 1724d43..813d726 100644
> --- a/fs/ocfs2/stack_o2cb.c
> +++ b/fs/ocfs2/stack_o2cb.c
> @@ -295,8 +295,8 @@ static int o2cb_cluster_check(void)
> set_bit(node_num, netmap);
> if (!memcmp(hbmap, netmap, sizeof(hbmap)))
> return 0;
> - if (i < O2CB_MAP_STABILIZE_COUNT)
> - msleep(1000);
> +
> + msleep(1000);
> }
I assume the code was intended to do
if (i < O2CB_MAP_STABILIZE_COUNT - 1)
msleep(1000);
to avoid a pointless 1-second delay when the operation times out.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-02-17 23:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 7:13 [PATCH 1/2] ocfs2: remove useless if statement Daeseok Youn
2015-02-17 23:30 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®