* [PATCH 2/2] ocfs2: remove unneeded 'rc' for kfree()
@ 2015-02-17 7:14 Daeseok Youn
0 siblings, 0 replies; only message in thread
From: Daeseok Youn @ 2015-02-17 7:14 UTC (permalink / raw)
To: mfasheh, akpm; +Cc: jlbec, ocfs2-devel, linux-kernel
If kzalloc() is failed, just goto 'out' label and
'out_free' label doesn't need to check 'rc' variable.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
fs/ocfs2/stack_o2cb.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
index 813d726..46ab104 100644
--- a/fs/ocfs2/stack_o2cb.c
+++ b/fs/ocfs2/stack_o2cb.c
@@ -347,7 +347,7 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn)
priv = kzalloc(sizeof(struct o2dlm_private), GFP_KERNEL);
if (!priv) {
rc = -ENOMEM;
- goto out_free;
+ goto out;
}
/* This just fills the structure in. It is safe to pass conn. */
@@ -376,8 +376,7 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn)
dlm_register_eviction_cb(dlm, &priv->op_eviction_cb);
out_free:
- if (rc)
- kfree(conn->cc_private);
+ kfree(conn->cc_private);
out:
return rc;
--
1.7.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-02-17 7:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 7:14 [PATCH 2/2] ocfs2: remove unneeded 'rc' for kfree() Daeseok Youn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®