mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/cma: Fix 64-bit size_t build warnings
@ 2015-02-19  1:06 Magnus Damm
  2015-02-19 10:46 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Magnus Damm @ 2015-02-19  1:06 UTC (permalink / raw)
  To: dri-devel
  Cc: airlied, Magnus Damm, laurent.pinchart+renesas, linux-kernel, linux-sh

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1618 bytes --]

From: Magnus Damm <damm+renesas@opensource.se>

Fix warnings related to size_t when building for 64-bit architectures:

drivers/gpu/drm/drm_gem_cma_helper.c: In function ‘drm_gem_cma_create’:
drivers/gpu/drm/drm_gem_cma_helper.c:114:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
    size);
    ^
drivers/gpu/drm/drm_gem_cma_helper.c: In function ‘drm_gem_cma_describe’:
drivers/gpu/drm/drm_gem_cma_helper.c:393:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 8 has type ‘size_t’ [-Wformat=]
    off, &cma_obj->paddr, cma_obj->vaddr, obj->size);

Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
---

 drivers/gpu/drm/drm_gem_cma_helper.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- 0001/drivers/gpu/drm/drm_gem_cma_helper.c
+++ work/drivers/gpu/drm/drm_gem_cma_helper.c	2015-02-19 06:29:39.155526831 +0900
@@ -110,7 +110,7 @@ struct drm_gem_cma_object *drm_gem_cma_c
 	cma_obj->vaddr = dma_alloc_writecombine(drm->dev, size,
 			&cma_obj->paddr, GFP_KERNEL | __GFP_NOWARN);
 	if (!cma_obj->vaddr) {
-		dev_err(drm->dev, "failed to allocate buffer with size %d\n",
+		dev_err(drm->dev, "failed to allocate buffer with size %zu\n",
 			size);
 		ret = -ENOMEM;
 		goto error;
@@ -388,7 +388,7 @@ void drm_gem_cma_describe(struct drm_gem
 
 	off = drm_vma_node_start(&obj->vma_node);
 
-	seq_printf(m, "%2d (%2d) %08llx %pad %p %d",
+	seq_printf(m, "%2d (%2d) %08llx %pad %p %zu",
 			obj->name, obj->refcount.refcount.counter,
 			off, &cma_obj->paddr, cma_obj->vaddr, obj->size);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/cma: Fix 64-bit size_t build warnings
  2015-02-19  1:06 [PATCH] drm/cma: Fix 64-bit size_t build warnings Magnus Damm
@ 2015-02-19 10:46 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-02-19 10:46 UTC (permalink / raw)
  To: Magnus Damm
  Cc: DRI Development, David Airlie, Laurent Pinchart, linux-kernel,
	Linux-sh list

On Thu, Feb 19, 2015 at 2:06 AM, Magnus Damm <magnus.damm@gmail.com> wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Fix warnings related to size_t when building for 64-bit architectures:
>
> drivers/gpu/drm/drm_gem_cma_helper.c: In function ‘drm_gem_cma_create’:

Content-Type: TEXT/PLAIN; charset=ISO-8859-1

But the atcual content is UTF8?

> drivers/gpu/drm/drm_gem_cma_helper.c:114:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
>     size);
>     ^
> drivers/gpu/drm/drm_gem_cma_helper.c: In function ‘drm_gem_cma_describe’:
> drivers/gpu/drm/drm_gem_cma_helper.c:393:4: warning: format ‘%d’ expects argument of type ‘int’, but argument 8 has type ‘size_t’ [-Wformat=]
>     off, &cma_obj->paddr, cma_obj->vaddr, obj->size);
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-19 10:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-19  1:06 [PATCH] drm/cma: Fix 64-bit size_t build warnings Magnus Damm
2015-02-19 10:46 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®