From: Tapasweni Pathak <tapaswenipathak@gmail.com>
To: gregkh@linuxfoundation.org, vinc94@gmail.com,
roberta.dobrescu@gmail.com, sachin.kamat@samsung.com,
ebru.akagunduz@gmail.com, damm+renesas@opensource.se,
chris@rorvick.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: tapaswenipathak@gmail.com, julia.lawall@lip6.fr
Subject: [PATCH] staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC
Date: Fri, 20 Feb 2015 18:43:53 +0530 [thread overview]
Message-ID: <20150220131336.GA22731@kt-Inspiron-3542> (raw)
To avoid deadlock, do not call blocking functions with spinlocks held.
Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile
doesn't have enough free pages but will not sleep and hence deadlock can
be avoided.
Found by Coccinelle.
Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
---
Is there any other way this can be fixed as it is better to avoid GFP_ATOMIC?
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 4be646c..6c1de27 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -2794,7 +2794,7 @@ static int nbu2ss_ep_queue(
if (ep->virt_buf == NULL)
ep->virt_buf = (u8 *)dma_alloc_coherent(
NULL, PAGE_SIZE,
- &ep->phys_buf, GFP_KERNEL | GFP_DMA);
+ &ep->phys_buf, GFP_ATOMIC | GFP_DMA);
if (ep->epnum > 0) {
if (ep->direct == USB_DIR_IN)
memcpy(ep->virt_buf, req->req.buf,
--
1.7.9.5
next reply other threads:[~2015-02-20 13:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:13 Tapasweni Pathak [this message]
2015-02-24 23:25 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150220131336.GA22731@kt-Inspiron-3542 \
--to=tapaswenipathak@gmail.com \
--cc=chris@rorvick.com \
--cc=damm+renesas@opensource.se \
--cc=devel@driverdev.osuosl.org \
--cc=ebru.akagunduz@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=roberta.dobrescu@gmail.com \
--cc=sachin.kamat@samsung.com \
--cc=vinc94@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®