Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 3153 bytes --]

Hi,

On Fri, Feb 20, 2015 at 10:15:52PM +0100, Pavel Machek wrote:
> On Fri 2015-02-20 08:39:06, Felipe Balbi wrote:
> > On Fri, Feb 20, 2015 at 09:27:51AM +0100, Pavel Machek wrote:
> > > > > > > > > In current state I review all 3 patches as:
> > > > > > > > > 
> > > > > > > > > Rejected-by: Pali Rohár <pali.rohar@gmail.com>
> > > > > > > > > [It breaks booting Nokia N900 device]
> > > > > > > > 
> > > > > > > > next step, figure why it's broken. Working just fine here
> > > > > > > > on AM335x which has the same musb IP.
> > > > > > > 
> > > > > > > Why is broken? That is easy. You send 3 patches which broke
> > > > > > > it.
> > > > > > 
> > > > > > Actually when I reverted only that patch which adds line:
> > > > > > 
> > > > > > pm_runtime_irq_safe(musb->controller)
> > > > > > 
> > > > > > then early boot crash disappeared.
> > > > > > 
> > > > > > But other two patches did not fixed support for external .ko
> > > > > > gadget modules. State is same -- crash after modprobe.
> > > > > 
> > > > > Here is crash from qemu when musb is compiled into kernel:
> > > > > 
> > > > > [    0.641662] Unable to handle kernel NULL pointer dereference at virtual address 00000000
> > > > > [    0.642211] pgd = c0004000
> > > ...
> > > > > [    0.672882] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
> > > > > [    0.672882]
> > > > > 
> > > > > Reason why it crashes is because when function
> > > > > omap2430_runtime_resume() is called pointer to functions 
> > > > > musb_readl and musb_writel are both NULL. And so NULL pointer
> > > > > dereference.
> > > > 
> > > > https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=1861a2c60351a390272b3395f4d88480cdfd9e58
> > > >
> > > 
> > > So you commit a fix to your internal branch without telling Pali, who
> > > is actively debugging same problem at the same time, and then you just
> > > send him url without at least saying "sorry"?
> > 
> > grow up... why do I have to say sorry for fixing a problem ? Why do I
> > have to let you know I committed something to my branch ? It's the
> 
> Because that's polite thing to do when you break someone elses system?

when did I break anything from you ? I sent you a patch to test which
you tested and reported it didn't work and the patch was removed from my
queue because of that. After that you completely refused to do any
work/debug related to an itch only *you* had to start with.

Seen as you just don't care to help yourself, why should I ?

You're 100% capable of debugging the problems you reported which I ended
up debugging even without having any HW which reproduced the failured.

Not to mention that since the beginning *you* have been the unpolite
one, completely reluctant to test anything or find logs because,
aparently, that's a waste of your o-so-valuable time.

So no, you DO NOT deserve any politeness. When you change your attitude
and start scratching your own itches, then we can talk about politeness;
until then, get used to a similarly aggressive attitude towards you.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]