From: David Miller <davem@davemloft.net>
To: sasha.levin@oracle.com
Cc: herbert@gondor.apana.org.au, tgraf@suug.ch,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rhashtable: initialize all rhashtable walker members
Date: Sun, 22 Feb 2015 16:29:41 -0500 (EST) [thread overview]
Message-ID: <20150222.162941.780862111589113271.davem@davemloft.net> (raw)
In-Reply-To: <54EA49E5.8040206@oracle.com>
From: Sasha Levin <sasha.levin@oracle.com>
Date: Sun, 22 Feb 2015 16:28:05 -0500
> On 02/22/2015 03:58 PM, David Miller wrote:
>> From: Sasha Levin <sasha.levin@oracle.com>
>> Date: Sat, 21 Feb 2015 15:55:11 -0500
>>
>>> Commit "rhashtable: Introduce rhashtable_walk_*" forgot to initialize the
>>> members of struct rhashtable_walker after allocating it, which caused
>>> an undefined value for 'resize' which is used later on.
>>>
>>> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>>
>> Commits should be referred to by SHA1 ID as well as the commit
>> header text (in parenthesis and double quotes).
>
> It wasn't (isn't?) in Linus' tree yet, so I didn't want to refer to
> it by a SHA1 ID which would change.
Commit IDs in my tree _NEVER_ change.
next prev parent reply other threads:[~2015-02-22 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 20:55 Sasha Levin
2015-02-22 20:58 ` David Miller
2015-02-22 21:28 ` Sasha Levin
2015-02-22 21:29 ` David Miller [this message]
2015-02-22 21:10 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150222.162941.780862111589113271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®