From: David Miller <davem@davemloft.net>
To: stathis.voukelatos@linn.co.uk
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 3/3] Linn Ethernet packet sniffer driver
Date: Mon, 23 Feb 2015 16:38:54 -0500 (EST) [thread overview]
Message-ID: <20150223.163854.880151768241069377.davem@davemloft.net> (raw)
In-Reply-To: <34013795c99ef50fac3d2c72717971563148578c.1424698609.git.stathis.voukelatos@linn.co.uk>
From: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
Date: Mon, 23 Feb 2015 14:26:22 +0000
> Driver for the Ethernet Mii packet sniffer H/W module found in
> the IMG Pistachio SoC.
>
> Signed-off-by: Stathis Voukelatos <stathis.voukelatos@linn.co.uk>
You really have to explain what this thing does, how it is used,
what APIs are made use of to maniulate this device, etc.
Nobody knows what the packet sniffer module by your company is.
I also anticipate that once you describe adequately how this thing
behaves I won't like it, and I'll prefer that you integrate support
for your device using an exising facility such as AF_PACKET,
extending it if need be.
I am very far away from applying this series at this point, it needs
a lot more work and explanations.
next prev parent reply other threads:[~2015-02-23 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 14:26 [PATCH v3 0/3] net: Linn Ethernet Packet Sniffer driver Stathis Voukelatos
2015-02-23 14:26 ` [PATCH v3 1/3] Ethernet packet sniffer: device tree binding and vendor prefix Stathis Voukelatos
2015-02-23 14:26 ` [PATCH v3 2/3] Packet sniffer core framework Stathis Voukelatos
2015-02-23 21:37 ` David Miller
2015-02-24 9:35 ` Stathis Voukelatos
2015-02-23 14:26 ` [PATCH v3 3/3] Linn Ethernet packet sniffer driver Stathis Voukelatos
2015-02-23 21:38 ` David Miller [this message]
2015-02-24 9:44 ` Stathis Voukelatos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150223.163854.880151768241069377.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stathis.voukelatos@linn.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®