From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Srivatsa S.Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smp: Remove CSD_FLAG_WAIT flag that's unused
Date: Fri, 27 Feb 2015 23:09:39 +0100 [thread overview]
Message-ID: <20150227220939.GU5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1425069373.9530.155.camel@schen9-desk2.jf.intel.com>
On Fri, Feb 27, 2015 at 12:36:13PM -0800, Tim Chen wrote:
>
> The CSD_FLAG_WAIT is not serving any useful purpose as we do not use
> its value to decide if we are going to wait for a smp call to complete.
> We also never cleared it properly when we are done waiting to indicate
> that the wait is over. So the WARNING debug check in csd_unlock is
> also not serving useful purpose. Propose here to remove it to clean up
> the code.
Linus had a much more comprehensive patch:
http://marc.info/?l=linux-kernel&m=142368734118230
prev parent reply other threads:[~2015-02-27 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 20:36 Tim Chen
2015-02-27 22:09 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227220939.GU5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome