mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: "Sanjeev Sharma" <sanjeev_sharma@mentor.com>,
	"Loïc Pellegrino" <oort10@gmail.com>,
	"Mohammad Jamal" <md.jamalmohiuddin@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and format string type connections
Date: Fri, 6 Mar 2015 16:54:55 -0800	[thread overview]
Message-ID: <20150307005455.GB11574@kroah.com> (raw)
In-Reply-To: <1423457188-4750-1-git-send-email-tolga.ceylan@gmail.com>

On Sun, Feb 08, 2015 at 08:46:28PM -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
> RT_TRACE format strings should specify unsigned instead of signed int

I don't understand, why did you do 2 different things in a single patch?

Please split this up.

Also:

>  		case RF90_PATH_C:
> -			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs, bRFSI_RFENV);
> +			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs,
> +				bRFSI_RFENV);

Please indent this to the character after '(' on the line above.

thanks,

greg k-h

      reply	other threads:[~2015-03-07 11:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09  4:46 Tolga Ceylan
2015-03-07  0:54 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150307005455.GB11574@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=md.jamalmohiuddin@gmail.com \
    --cc=oort10@gmail.com \
    --cc=sanjeev_sharma@mentor.com \
    --cc=tolga.ceylan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®