From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: fix braino in ->poll()
Date: Mon, 9 Mar 2015 15:41:51 -0400 [thread overview]
Message-ID: <20150309194151.GB2627@fieldses.org> (raw)
In-Reply-To: <20150307210846.GF29656@ZenIV.linux.org.uk>
On Sat, Mar 07, 2015 at 09:08:46PM +0000, Al Viro wrote:
> POLL_OUT isn't what callers of ->poll() are expecting to see; it's
> actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap
> bit...
Thanks!--b.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 33fb105..5199bb1 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -921,7 +921,7 @@ static unsigned int cache_poll(struct file *filp, poll_table *wait,
> poll_wait(filp, &queue_wait, wait);
>
> /* alway allow write */
> - mask = POLL_OUT | POLLWRNORM;
> + mask = POLLOUT | POLLWRNORM;
>
> if (!rp)
> return mask;
next prev parent reply other threads:[~2015-03-09 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 15:49 [RFC] ->poll() bugs Al Viro
2015-03-05 15:58 ` Al Viro
2015-03-07 20:44 ` Al Viro
2015-03-07 20:53 ` Linus Torvalds
2015-03-07 21:03 ` Al Viro
2015-03-07 21:08 ` [PATCH] sunrpc: fix braino in ->poll() Al Viro
2015-03-09 19:41 ` J. Bruce Fields [this message]
2015-03-08 1:33 ` [RFC] ->poll() bugs Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309194151.GB2627@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®