mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Daniel J Blueman <daniel@numascale.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Steffen Persvold <sp@numascale.com>
Subject: Re: [PATCH v4] x86: Fix sibling map with NumaChip
Date: Thu, 12 Mar 2015 15:50:01 +0100	[thread overview]
Message-ID: <20150312145001.GB25505@pd.tnic> (raw)
In-Reply-To: <1426135950-10110-1-git-send-email-daniel@numascale.com>

On Thu, Mar 12, 2015 at 12:52:30PM +0800, Daniel J Blueman wrote:
> On NumaChip systems, the physical processor ID assignment wasn't accounting
> for the number of nodes in AMD multi-module processors, giving an incorrect
> sibling map:
> 
> $ cd /sys/devices/system/cpu/cpu29/topology
> $ grep . *
> core_id:5
> core_siblings:00000000,ff000000
> core_siblings_list:24-31
> physical_package_id:3
> thread_siblings:00000000,30000000
> thread_siblings_list:28-29
> 
> After fixing:
> 
> core_id:5
> core_siblings:00000000,ffff0000
> core_siblings_list:16-31
> physical_package_id:1
> thread_siblings:00000000,30000000
> thread_siblings_list:28-29
> 
> v2: Fix to check for MSR availability before use, as per Boris's feedback
> v3: Test against boot cpu to correct behaviour on larger systems with global IO
> v4: Use static_cpu_has_safe(), as Boris suggests
> 
> Candidate for stable.
> 
> Signed-off-by: Daniel J Blueman <daniel@numascale.com>
> ---
>  arch/x86/kernel/apic/apic_numachip.c | 22 ++++++++++++++++------
>  1 file changed, 16 insertions(+), 6 deletions(-)

Queued for urgent/stable.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

  reply	other threads:[~2015-03-12 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12  4:52 Daniel J Blueman
2015-03-12 14:50 ` Borislav Petkov [this message]
2015-03-16 12:06 ` [tip:x86/urgent] x86/apic/numachip: " tip-bot for Daniel J Blueman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312145001.GB25505@pd.tnic \
    --to=bp@alien8.de \
    --cc=daniel@numascale.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sp@numascale.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®