mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: oleg@redhat.com, mhocko@suse.cz, mingo@kernel.org,
	peterz@infradead.org, ionut.m.alexa@gmail.com, riel@redhat.com,
	peter@hurleysoftware.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h
Date: Thu, 12 Mar 2015 16:16:36 -0700	[thread overview]
Message-ID: <20150312161636.1e450cca1f4cad34555b751c@linux-foundation.org> (raw)
In-Reply-To: <1426048610-6065-1-git-send-email-xerofoify@gmail.com>

On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause <xerofoify@gmail.com> wrote:

>  This fixes the function definiton of do_exit to comply with its
>  function prototype as  defined in kernel.h as found when running 
>  sparse on the latest updated version of the mainline kernel.
> 
> ...
>
> -void do_exit(long code)
> +void do_exit(long error_code)

We still have

include/linux/module.h:#define module_put_and_exit(code) do_exit(code)

Probably changing the header files is the way to go - error_code is a
bit of a mouthful.

Actually, using "exit_code" everywhere would be best - that's what the
thing does, and it gets copied into task_struct.exit_code.

And change complete_and_exit(code).

do_group_exit() already uses exit_code.

sys_exit_group() uses "error_code".

It's rather a little mess we've made in there!

           reply	other threads:[~2015-03-12 23:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1426048610-6065-1-git-send-email-xerofoify@gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312161636.1e450cca1f4cad34555b751c@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ionut.m.alexa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peter@hurleysoftware.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®