Re: [PATCH] x86: simplify task_pt_regs() macro definition

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 13 Mar 2015 15:09:03 +0100
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> Before this change, task_pt_regs() was using KSTK_TOP(),
> and it was the only use of that macro. In turn, KSTK_TOP used
> THREAD_SIZE_LONGS, and it was the only use of that macro too.
> 
> Fold these macros into task_pt_regs(). Tweak comment
> about "- 8" - we now use a symbolic constant, not literal 8.

I wonder if we should mention "8" at all?

As for the patch, from what I can tell, it keeps the same logic.

Reviewed-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Linus Torvalds <torvalds@linux-foundation.org>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Borislav Petkov <bp@alien8.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: Andy Lutomirski <luto@amacapital.net>
> CC: Oleg Nesterov <oleg@redhat.com>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Alexei Starovoitov <ast@plumgrid.com>
> CC: Will Drewry <wad@chromium.org>
> CC: Kees Cook <keescook@chromium.org>
> CC: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
>  arch/x86/include/asm/processor.h | 20 ++++++--------------
>  1 file changed, 6 insertions(+), 14 deletions(-)