From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lee.jones@linaro.org, sameo@linux.intel.com, lgirdwood@gmail.com,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode
Date: Mon, 16 Mar 2015 17:17:55 +0000 [thread overview]
Message-ID: <20150316171755.GV28806@sirena.org.uk> (raw)
In-Reply-To: <1426525124-12317-5-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 754 bytes --]
On Mon, Mar 16, 2015 at 04:58:44PM +0000, Charles Keepax wrote:
> + } else {
> + switch (arizona->type) {
> + case WM5110:
> + case WM8280:
> + ret = regulator_set_voltage(arizona->dcvdd,
> + 1175000, 1175000);
> + if (ret < 0) {
Can we please have a comment about this being the internal LDO and us
therefore knowing exactly what voltages it supports (or just that it's
the on chip LDO)? Going for a single voltage with zero tolerance is
usually bad practice since it causes needless interoperability issues
(eg, here the chances that the hardware would mind if an external
regulator were only able to deliver 1.174V rather than 1.175V are
minimal). This is fine here but people might be looking for examples
and get the wrong idea.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-16 17:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 16:58 [PATCH 1/5] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Charles Keepax
2015-03-16 16:58 ` [PATCH 2/5] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-03-16 16:58 ` [PATCH 3/5] mfd: wm5110: Add delay before releasing reset line on cold boot Charles Keepax
2015-03-16 17:12 ` Mark Brown
2015-03-16 18:45 ` Charles Keepax
2015-03-16 20:47 ` Mark Brown
2015-03-17 11:50 ` Charles Keepax
2015-03-17 12:04 ` Mark Brown
2015-03-17 13:01 ` Charles Keepax
2015-03-16 16:58 ` [PATCH 4/5] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-03-16 17:18 ` Mark Brown
2015-03-16 16:58 ` [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-03-16 17:17 ` Mark Brown [this message]
2015-03-16 18:28 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150316171755.GV28806@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®