Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Mon, Mar 16, 2015 at 11:51:15PM -0400, nick wrote:
> 
> 
> On 2015-03-16 11:37 PM, Peter Chen wrote:
> >  
> >>
> >> Greetings All,
> >> I have been getting the below build warnings:
> >> drivers/usb/renesas_usbhs/common.c: In function ‘usbhs_parse_dt’:
> >> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer to
> >> integer of different size [-Wpointer-to-int-cast]
> >> dparam->type = of_id ? (u32)of_id->data : 0;
> >> After looking into the function I am curious if the hardware is only 32 bit as if
> >> the supported hardware for this driver is then this cast is no longer required
> >> and I can send in a patch removing it. Furthermore, sorry for the simple
> >> question but  I don't have access to the device specs for supported hardware
> >> so I though it would be better to ask before I send in patch fixing this issue.
> >> Thanks,
> >> Nick
> > 
> > Patch is welcome, there will be comment if it is not suitable.
> > 
> > Peter
> > 
> I understand that,my question was does the hardware for this driver support 64 bit.

regardless, it shouldn't produce a build warning.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]