From: Peter Zijlstra <peterz@infradead.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: mingo@kernel.org, rusty@rustcorp.com.au, oleg@redhat.com,
paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, andi@firstfloor.org,
rostedt@goodmis.org, tglx@linutronix.de,
David Woodhouse <David.Woodhouse@intel.com>,
Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Michel Lespinasse <walken@google.com>
Subject: Re: [PATCH 5/8] seqlock: Better document raw_write_seqcount_latch()
Date: Wed, 18 Mar 2015 15:50:56 +0100 [thread overview]
Message-ID: <20150318145056.GO23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <80740165.31353.1426688975785.JavaMail.zimbra@efficios.com>
On Wed, Mar 18, 2015 at 02:29:35PM +0000, Mathieu Desnoyers wrote:
> > + * struct entry *latch_query(struct latch_struct *latch, ...)
> > + * {
> > + * struct entry *entry;
> > + * unsigned seq;
> > + * int idx;
>
> very minor nit: why is seq unsigned, but idx a signed int ?
> Could we do:
>
> unsigned seq, idx; instead ?
>
> Other than that:
>
> Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Done and thanks!
next prev parent reply other threads:[~2015-03-18 14:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 13:36 [PATCH 0/8] latched RB-trees and __module_address() Peter Zijlstra
2015-03-18 13:36 ` [PATCH 1/8] module: Sanitize RCU usage and locking Peter Zijlstra
2015-03-20 3:36 ` Rusty Russell
2015-03-18 13:36 ` [PATCH 2/8] module: Annotate module version magic Peter Zijlstra
2015-03-18 13:36 ` [PATCH 3/8] module, jump_label: Fix module locking Peter Zijlstra
2015-03-20 4:26 ` Rusty Russell
2015-03-20 9:11 ` Peter Zijlstra
2015-03-18 13:36 ` [PATCH 4/8] rbtree: Make lockless searches non-fatal Peter Zijlstra
2015-03-18 13:36 ` [PATCH 5/8] seqlock: Better document raw_write_seqcount_latch() Peter Zijlstra
2015-03-18 14:29 ` Mathieu Desnoyers
2015-03-18 14:50 ` Peter Zijlstra [this message]
2015-03-18 13:36 ` [PATCH 6/8] rbtree: Implement generic latch_tree Peter Zijlstra
2015-03-18 16:20 ` Ingo Molnar
2015-03-19 5:14 ` Andrew Morton
2015-03-19 7:25 ` Peter Zijlstra
2015-03-19 20:58 ` Andrew Morton
2015-03-19 21:36 ` Steven Rostedt
2015-03-19 21:38 ` Steven Rostedt
2015-03-19 21:47 ` Andrew Morton
2015-03-19 21:54 ` Steven Rostedt
2015-03-19 22:12 ` Peter Zijlstra
2015-03-19 22:04 ` Peter Zijlstra
2015-03-20 9:50 ` Peter Zijlstra
2015-03-19 22:10 ` Peter Zijlstra
2015-03-18 13:36 ` [PATCH 7/8] module: Optimize __module_address() using a latched RB-tree Peter Zijlstra
2015-03-18 13:36 ` [PATCH 8/8] module: Use __module_address() for module_address_lookup() Peter Zijlstra
2015-03-18 14:21 ` [PATCH 0/8] latched RB-trees and __module_address() Christoph Hellwig
2015-03-18 14:38 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318145056.GO23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=David.Woodhouse@intel.com \
--cc=aarcange@redhat.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome