mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: David Cohen <david.a.cohen@linux.intel.com>
Cc: Felipe Balbi <balbi@ti.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Baolu Lu <baolu.lu@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails
Date: Thu, 19 Mar 2015 13:51:20 +0200	[thread overview]
Message-ID: <20150319115120.GC2435@kuha.fi.intel.com> (raw)
In-Reply-To: <20150318170855.GB25477@psi-dev26.jf.intel.com>

> > @@ -65,6 +76,31 @@ static int dwc3_pci_quirks(struct pci_dev *pdev)
> >  						sizeof(pdata));
> >  	}
> >  
> > +	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
> > +	    pdev->device == PCI_DEVICE_ID_INTEL_BYT) {
> > +		struct gpio_desc *gpio;
> > +
> > +		acpi_dev_add_driver_gpios(ACPI_COMPANION(&pdev->dev),
> > +					  acpi_dwc3_byt_gpios);
> > +
> > +		gpio = gpiod_get(&pdev->dev, "reset");
> > +		if (IS_ERR(gpio))
> > +			return 0;
> > +
> > +		/* These GPIOs will turn on the USB2 PHY */
> > +		gpiod_direction_output(gpio, 0);
> > +		gpiod_set_value_cansleep(gpio, 1);
> > +		gpiod_put(gpio);
> > +
> > +		gpio = gpiod_get(&pdev->dev, "cs");
> 
> CS GPIO should be handled before RESET.

OK, I'll fix it.


Thanks,

-- 
heikki

  reply	other threads:[~2015-03-19 11:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 12:40 [PATCHv2 00/12] usb: ulpi bus Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 01/12] usb: add bus type for USB ULPI Heikki Krogerus
2015-03-18 23:26   ` Paul Bolle
2015-03-19 11:44     ` Heikki Krogerus
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-26 14:02         ` [PATCHv4 " Heikki Krogerus
2015-03-23  7:16   ` [PATCHv2 " Lu, Baolu
2015-03-23 10:57     ` Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 02/12] usb: dwc3: USB2 PHY register access bits Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 03/12] usb: dwc3: ULPI or UTMI+ select Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 04/12] usb: dwc3: store driver data earlier Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 05/12] usb: dwc3: cache hwparams earlier Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 06/12] usb: dwc3: soft reset to it's own function Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 07/12] usb: dwc3: setup phys earlier Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 08/12] usb: dwc3: add hsphy_interface property Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 09/12] usb: dwc3: pci: add quirk for Baytrails Heikki Krogerus
2015-03-18 17:08   ` David Cohen
2015-03-19 11:51     ` Heikki Krogerus [this message]
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 10/12] usb: dwc3: add ULPI interface support Heikki Krogerus
2015-03-18 22:53   ` Paul Bolle
2015-03-19 11:48     ` Heikki Krogerus
2015-03-20 12:20       ` [PATCHv3 " Heikki Krogerus
2015-03-18 12:40 ` [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering Heikki Krogerus
2015-03-18 14:46   ` Sergei Shtylyov
2015-03-18 16:54     ` David Cohen
2015-03-18 18:02       ` Sergei Shtylyov
2015-03-18 12:40 ` [PATCHv2 12/12] phy: add driver for TI TUSB1210 ULPI PHY Heikki Krogerus
2015-03-18 17:12 ` [PATCHv2 00/12] usb: ulpi bus David Cohen
2015-03-18 17:19   ` David Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319115120.GC2435@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=balbi@ti.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=david.a.cohen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome