mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: kent.overstreet@gmail.com, Benjamin LaHaise <bcrl@kvack.org>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: serial percpu_ref draining in exit_aio()
Date: Thu, 19 Mar 2015 13:34:13 -0400	[thread overview]
Message-ID: <20150319173413.GU25365@htj.duckdns.org> (raw)

Hello,

So, Jens noticed that fio process exiting takes seconds when there are
multiple aio contexts and the culprit seems to be the serial
percpu_ref draining in exit_aio().  It's generally a bad idea to
expose RCU latencies to userland because they add up really quickly
and are unrelated to other performance parameters.  Can you guys
please at least update the code so that it waits for all percpu_refs
to drain at the same time rather than one after another?  That should
resolve the worst part of the problem.

Thanks.

-- 
tejun

             reply	other threads:[~2015-03-19 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 17:34 Tejun Heo [this message]
2015-03-19 20:25 ` Jens Axboe
2015-03-19 20:58   ` Jeff Moyer
2015-03-19 21:00     ` Tejun Heo
2015-03-19 21:27       ` Jens Axboe
2015-03-19 21:43         ` Jens Axboe
2015-03-20 18:56           ` Jeff Moyer
2015-03-20 19:21             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319173413.GU25365@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®