mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	kent.overstreet@gmail.com, Benjamin LaHaise <bcrl@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: serial percpu_ref draining in exit_aio()
Date: Thu, 19 Mar 2015 17:00:51 -0400	[thread overview]
Message-ID: <20150319210051.GE19657@htj.duckdns.org> (raw)
In-Reply-To: <x494mpg66x2.fsf@segfault.boston.devel.redhat.com>

On Thu, Mar 19, 2015 at 04:58:33PM -0400, Jeff Moyer wrote:
> Do you really want to do memory allocation in the exit path?  That
> sounds like a bad idea to me.  (Of course, now you're going to point out
> all the places that currently happens, right?  ;-)

I think we just need a counter there - let everyone count down as they
exit and the last one trigger the completion, no?

-- 
tejun

  reply	other threads:[~2015-03-19 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 17:34 Tejun Heo
2015-03-19 20:25 ` Jens Axboe
2015-03-19 20:58   ` Jeff Moyer
2015-03-19 21:00     ` Tejun Heo [this message]
2015-03-19 21:27       ` Jens Axboe
2015-03-19 21:43         ` Jens Axboe
2015-03-20 18:56           ` Jeff Moyer
2015-03-20 19:21             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319210051.GE19657@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bcrl@kvack.org \
    --cc=jmoyer@redhat.com \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®