* [PATCH] ASoC: max98925: Constify regmap config and other codec data
@ 2015-03-20 11:35 Krzysztof Kozlowski
2015-03-20 11:51 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-20 11:35 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel
Cc: Krzysztof Kozlowski
Constify local structures (snd_soc_dai_ops, snd_soc_codec_driver,
regmap_config) and array (reg_defaults) which are not modified by the
driver and passed to core as pointer to const.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
sound/soc/codecs/max98925.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/max98925.c b/sound/soc/codecs/max98925.c
index 1f8e80315749..0796dfaeb139 100644
--- a/sound/soc/codecs/max98925.c
+++ b/sound/soc/codecs/max98925.c
@@ -34,7 +34,7 @@ static const char *const hpf_text[] = {
"Disable", "DC Block", "100Hz", "200Hz", "400Hz", "800Hz",
};
-static struct reg_default max98925_reg[] = {
+static const struct reg_default max98925_reg[] = {
{ 0x0B, 0x00 }, /* IRQ Enable0 */
{ 0x0C, 0x00 }, /* IRQ Enable1 */
{ 0x0D, 0x00 }, /* IRQ Enable2 */
@@ -491,7 +491,7 @@ static int max98925_dai_set_sysclk(struct snd_soc_dai *dai,
#define MAX98925_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \
SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
-static struct snd_soc_dai_ops max98925_dai_ops = {
+static const struct snd_soc_dai_ops max98925_dai_ops = {
.set_sysclk = max98925_dai_set_sysclk,
.set_fmt = max98925_dai_set_fmt,
.hw_params = max98925_dai_hw_params,
@@ -541,7 +541,7 @@ static int max98925_probe(struct snd_soc_codec *codec)
return 0;
}
-static struct snd_soc_codec_driver soc_codec_dev_max98925 = {
+static const struct snd_soc_codec_driver soc_codec_dev_max98925 = {
.probe = max98925_probe,
.controls = max98925_snd_controls,
.num_controls = ARRAY_SIZE(max98925_snd_controls),
@@ -551,7 +551,7 @@ static struct snd_soc_codec_driver soc_codec_dev_max98925 = {
.num_dapm_widgets = ARRAY_SIZE(max98925_dapm_widgets),
};
-static struct regmap_config max98925_regmap = {
+static const struct regmap_config max98925_regmap = {
.reg_bits = 8,
.val_bits = 8,
.max_register = MAX98925_REV_VERSION,
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: max98925: Constify regmap config and other codec data
2015-03-20 11:35 [PATCH] ASoC: max98925: Constify regmap config and other codec data Krzysztof Kozlowski
@ 2015-03-20 11:51 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-03-20 11:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 276 bytes --]
On Fri, Mar 20, 2015 at 12:35:45PM +0100, Krzysztof Kozlowski wrote:
> Constify local structures (snd_soc_dai_ops, snd_soc_codec_driver,
> regmap_config) and array (reg_defaults) which are not modified by the
> driver and passed to core as pointer to const.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-20 11:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-20 11:35 [PATCH] ASoC: max98925: Constify regmap config and other codec data Krzysztof Kozlowski
2015-03-20 11:51 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®