From: Mark Brown <broonie@kernel.org>
To: Bert Vermeulen <bert@biot.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: Add SPI driver for Mikrotik RB4xx series boards
Date: Fri, 20 Mar 2015 12:56:27 +0000 [thread overview]
Message-ID: <20150320125627.GK2869@sirena.org.uk> (raw)
In-Reply-To: <1426853793-24454-2-git-send-email-bert@biot.com>
[-- Attachment #1: Type: text/plain, Size: 683 bytes --]
On Fri, Mar 20, 2015 at 01:16:32PM +0100, Bert Vermeulen wrote:
> index 856d34d..0d55661 100644
> --- a/include/linux/spi/spi.h
> +++ b/include/linux/spi/spi.h
> @@ -616,6 +616,7 @@ struct spi_transfer {
> struct sg_table rx_sg;
>
> unsigned cs_change:1;
> + unsigned fast_write:1;
> unsigned tx_nbits:3;
> unsigned rx_nbits:3;
> #define SPI_NBITS_SINGLE 0x01 /* 1bit transfer */
One other thing I just noticed: this is extending the core with no
documentation or other comment on what it's supposed to do (there's no
commit message at all). Any changes to the core should be a separate
patch which makes it clear what the changes are supposed to do.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-20 12:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 12:16 [PATCH 0/2] spi: Add driver for Routerboard RB4xx boards Bert Vermeulen
2015-03-20 12:16 ` [PATCH 1/2] spi: Add SPI driver for Mikrotik RB4xx series boards Bert Vermeulen
2015-03-20 12:51 ` Mark Brown
2015-03-22 11:25 ` Bert Vermeulen
2015-03-22 16:17 ` Mark Brown
2015-03-20 12:56 ` Mark Brown [this message]
2015-03-25 21:40 ` Andy Shevchenko
2015-03-20 12:16 ` [PATCH 2/2] spi: Add driver for the CPLD chip on Mikrotik RB4xx boards Bert Vermeulen
2015-03-20 13:28 ` Mark Brown
2015-03-25 21:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320125627.GK2869@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-spi@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome