From: Mark Brown <broonie@kernel.org>
To: Bert Vermeulen <bert@biot.com>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/2] spi: Add SPI driver for Mikrotik RB4xx series boards
Date: Sun, 22 Mar 2015 16:17:37 +0000 [thread overview]
Message-ID: <20150322161737.GE6643@sirena.org.uk> (raw)
In-Reply-To: <550EA6A4.6010206@biot.com>
[-- Attachment #1: Type: text/plain, Size: 884 bytes --]
On Sun, Mar 22, 2015 at 12:25:24PM +0100, Bert Vermeulen wrote:
> It is bitbanging, at least on write. The hardware has a shift register that
> is uses for reads. The generic spi for this board's architecture (ath79)
> indeed uses spi-bitbang.
> This "fast SPI" thing is what makes this one different: the boot flash and
> MMC use regular SPI on the same bus as the CPLD. This CPLD needs this fast
> SPI: a mode where it shifts in two bits per clock. The second bit is
> apparently sent via the CS2 pin.
Please make sure that all this is visible to someone looking at the
driver, it's really not at all clear what's going on just from reading
the code.
> So I don't think spi-bitbang will do. I need to see about reworking things
> to use less custom queueing -- I'm not that familiar with this yet.
Mostly it's just a case of deleting the loops and using the core ones
instead.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-23 5:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 12:16 [PATCH 0/2] spi: Add driver for Routerboard RB4xx boards Bert Vermeulen
2015-03-20 12:16 ` [PATCH 1/2] spi: Add SPI driver for Mikrotik RB4xx series boards Bert Vermeulen
2015-03-20 12:51 ` Mark Brown
2015-03-22 11:25 ` Bert Vermeulen
2015-03-22 16:17 ` Mark Brown [this message]
2015-03-20 12:56 ` Mark Brown
2015-03-25 21:40 ` Andy Shevchenko
2015-03-20 12:16 ` [PATCH 2/2] spi: Add driver for the CPLD chip on Mikrotik RB4xx boards Bert Vermeulen
2015-03-20 13:28 ` Mark Brown
2015-03-25 21:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322161737.GE6643@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-spi@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®