From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lee.jones@linaro.org, sameo@linux.intel.com,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit
Date: Tue, 24 Mar 2015 09:06:43 -0700 [thread overview]
Message-ID: <20150324160642.GE17265@sirena.org.uk> (raw)
In-Reply-To: <1427209192-12795-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
On Tue, Mar 24, 2015 at 02:59:48PM +0000, Charles Keepax wrote:
> - if (arizona->pdata.reset)
> + if (arizona->pdata.reset) {
> gpio_set_value_cansleep(arizona->pdata.reset, 0);
> + gpio_free(arizona->pdata.reset);
> + }
Or acquire the GPIO with devm_ and avoid having to explicitly free it at
all?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-03-24 16:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 14:59 [PATCH 0/5] wm5110 Boot Fixups Part 2 Charles Keepax
2015-03-24 14:59 ` [PATCH 1/5] mfd: arizona: Add missing gpio_free in arizona_dev_exit Charles Keepax
2015-03-24 16:06 ` Mark Brown [this message]
2015-03-24 16:51 ` Charles Keepax
2015-03-24 14:59 ` [PATCH 2/5] mfd: wm5102: Move check for custom boot into arizona_wait_for_boot Charles Keepax
2015-03-24 14:59 ` [PATCH 3/5] mfd: arizona: Factor out hard reset into helper functions Charles Keepax
2015-03-24 14:59 ` [PATCH 4/5] mfd: arizona: Add better support for system suspend Charles Keepax
2015-03-24 14:59 ` [PATCH 5/5] mfd: wm5110: Add delay before releasing reset line Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324160642.GE17265@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome