From: Felipe Balbi <balbi@ti.com>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Peter Chen <peter.chen@freescale.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: Check for NULL pointer in disconnect
Date: Tue, 24 Mar 2015 11:30:08 -0500 [thread overview]
Message-ID: <20150324163008.GB31024@saruman.tx.rr.com> (raw)
In-Reply-To: <55109B15.9080800@google.com>
[-- Attachment #1: Type: text/plain, Size: 568 bytes --]
On Mon, Mar 23, 2015 at 04:00:37PM -0700, Badhri Jagan Sridharan wrote:
> > Do you really see some udc drivers call it after composite_unbind is
> > called? If it is, you may add dump_stack() to track that error.
> >
> > Besides this, function suspended_show is needed to add cdev NULL pointer
> > checking.
>
> We see this happening occasionally in *not yet* upstreamed UDC
> code of some vendors (Yes, disconnect being called after unbind)
fix your UDC. We leave these sort of thing open so people realise they
have to fix their drivers.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-03-24 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 23:40 Badhri Jagan Sridharan
2015-03-22 7:43 ` Peter Chen
2015-03-23 23:00 ` Badhri Jagan Sridharan
2015-03-24 8:39 ` Peter Chen
2015-03-24 16:30 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150324163008.GB31024@saruman.tx.rr.com \
--to=balbi@ti.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®