From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: shuahkh@osg.samsung.com, <linux-kernel@vger.kernel.org>,
davej@codemonkey.org.uk, namhyung@kernel.org
Subject: Re: [PATCH v2] ftracetest: Convert exit -1 to exit $FAIL
Date: Mon, 30 Mar 2015 15:50:50 -0400 [thread overview]
Message-ID: <20150330155050.4715e9fb@gandalf.local.home> (raw)
In-Reply-To: <1427692860-6423-1-git-send-email-mpe@ellerman.id.au>
On Mon, 30 Mar 2015 16:21:00 +1100
Michael Ellerman <mpe@ellerman.id.au> wrote:
> POSIX says that exit takes an unsigned integer between 0 and 255, so
> using -1 doesn't work on POSIX shells.
>
> There is already a well-defined failure code, $FAIL (1), so use that.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> ---
>
> v2: Use exit $FAIL not exit 255.
>
> tools/testing/selftests/ftrace/test.d/00basic/basic4.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter-stack.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/fgraph-filter.tc | 2 +-
> tools/testing/selftests/ftrace/test.d/ftrace/func_profiler.tc | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
next prev parent reply other threads:[~2015-03-30 19:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 5:21 Michael Ellerman
2015-03-30 19:50 ` Steven Rostedt [this message]
2015-03-31 16:17 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330155050.4715e9fb@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=shuahkh@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®